refactor(cni): promote hostgw out of the veth plugin's tree - #362
Open
ecv wants to merge 1 commit into
Open
Conversation
Three shared packages moved out from under internal/cni in #315 so the other chain binaries stop reaching into one plugin's own tree for things all of them use. hostgw met the same description and stayed behind. It is the strongest case of the four, not the weakest: hostconf, crdnames and nadpatch are schema and naming helpers, while hostgw configures kernel state on an interface, and two binaries outside its parent (galactic-tap, via internal/cnitap; galactic-veth's own internal/cni) call it to do that. The move is mechanical. The package name does not change, every call site is an import line, and no behavior changes. While updating the architecture reference, its module tree still showed hostconf, crdnames and nadpatch nested under internal/cni as well. That has been stale since #315 promoted them; the tree and the unit-test package list now match the filesystem for all four. Related to #344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four packages under the veth plugin's tree were shared by binaries outside it. Three moved up a level earlier so the other chain binaries stop reaching into one plugin's internals for things all of them use. The fourth stayed behind.
This moves it, and it is the one with the strongest case. The other three are schema and naming helpers. This one configures kernel state on an interface, and two binaries outside its parent call it to do that.
Nothing about the code changes. The package name is the same, every call site is an import line, and no behavior moves with it.
One thing found on the way: the architecture reference's module tree still showed the other three nested where they no longer are. That has been stale since they moved. The tree and the unit-test package list now match the filesystem for all four.
Test plan
task linttask buildtask test:unittask test:e2eAll four ride on CI here rather than locally.
Related to #344