fix(gobgp): advertise L2VPN/EVPN capability instead of IPv4/IPv6 Unicast#119
Merged
Conversation
scotwells
previously approved these changes
Jun 17, 2026
scotwells
left a comment
scotwells
left a comment
Contributor
There was a problem hiding this comment.
Got some merge conflicts, but changes look good.
Resolve merge conflicts introduced by the internal/plumbing/ refactor that landed on main while this branch was in flight: - ARCHITECTURE.md: drop the removed internal/cni/bgp/ entry from the repo layout tree and component table; adopt the internal/plumbing/* entries from main - scripts/ci.sh: adopt main's GITHUB_ACTIONS guard for the apt-get block; keep modprobe vrf outside the conditional so it runs locally Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
privateip
force-pushed
the
fix/gobgp-l2vpn-evpn-capabilities
branch
from
eb2669c to
71e9d3f
Compare
scotwells
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CapabilitiesRPC to advertiseL2VPN/EVPN(AFI=25, SAFI=70) as the sole address family, replacing the incorrectIPv4/UnicastandIPv6/UnicastentriesafiL2VPNandsafiEVPNconstants to satisfygoconstlint rulesinternal/gobgp/provider_test.gowith 8 tests defending the capabilities contract andfamilyFromSpecmappingsARCHITECTURE.mdto reflect EVPN throughout (overview, component table, key design decisions)apt-getblock inscripts/ci.shbehindcommand -v apt-getso the e2e suite runs on non-Ubuntu hosts (e.g. Fedora)Test plan
task cipasses (lint, build, unit tests, e2e)TestCapabilities_AddressFamilyasserts AFI=L2VPN, SAFI=EVPNTestCapabilities_NoUnicastasserts no Unicast AF is advertisedTestCapabilities_DoesNotRequireLiveBGPasserts Capabilities works without a running GoBGP instanceTestFamilyFromSpec_L2VPN_EVPNasserts the string mapping resolves to the correct GoBGP API constants🤖 Generated with Claude Code