Skip to content

The gateway stack only builds on one laptop #358

Description

@ecv

What needs to happen

Every branch in the edge gateway stack from the controllers branch onward pins the shared network API to a sibling checkout on one developer's laptop instead of to a published version. Nothing outside that laptop can build.

CI is red on all six of those pull requests. Lint, Build, Unit Tests, Unit Tests (root), and every image publish job fail at module resolution. The failure is not scoped to the new gateway code. The whole module stops resolving, including packages that predate this work.

Two production container images inherited the same coupling. Both now expect the caller to hand them that sibling checkout as a named build context. The local lab passes it. The publish pipeline does not, so image builds break once this reaches the default branch.

The lab bring-up script reads the new custom resource definitions out of the sibling checkout as well, rather than from anything the repo or the cluster provides.

Why this matters

The stack is seven pull requests deep and every branch below the origin carries the same line by inheritance. Anyone who checks out one of these branches, or reviews it, or lets CI run on it, sees a failure that has nothing to do with the change under review. Real defects hide behind noise like that.

It also survives merge. The two images that now require the extra build context are the ones the publish pipeline pushes, so the first release after this lands produces nothing.

Desired outcome

  1. Re-pin the network API dependency to a published version and delete the local path override and its comment block.
  2. Remove the matching build-context requirement from both container images.
  3. Let the lab bring-up install the new custom resource definitions from a published source rather than a sibling checkout.
  4. Confirm the re-pin compiles against the upstream shape, since the override may have been masking drift.

The upstream types this override was waiting on have already landed on the network repository's default branch, so step one is unblocked today.

Found while reviewing #350 through #356.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpriority/highHigh priority bug — should be fixed before next release

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions