JCU/Customize docker#1334
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR customizes the GitHub Actions CI and Docker image workflows for the dataquest-dev/dspace-angular repository and customer branches, including new build triggers and a deployment hook.
Changes:
- Update CI workflow triggers and tool versions (actions versions, Node matrix, caching steps).
- Update Docker image workflow to build/push
dataquest/dspace-angularimages using adataquest-dev/DSpacereusable workflow. - Replace the prior Docker deploy/test job with a reusable-workflow-based
deployjob.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .github/workflows/docker.yml | Adjusts Docker build triggers and switches image build/push to dataquest/*, adds a deployment job hook. |
| .github/workflows/build.yml | Updates CI triggers, action versions, Node matrix, and caching/install steps for customer-focused CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Save those in an Artifact | ||
| - name: Upload e2e test failure screenshots to Artifacts | ||
| uses: actions/upload-artifact@v7 | ||
| uses: actions/upload-artifact@v4 |
| CONFIG_PATH: /opt/dspace-envs/${{inputs.INSTANCE}} | ||
| ENVFILE: /opt/dspace-envs/${{inputs.INSTANCE}}/.env | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Maybe bigger version of checkout should be used
| timeout-minutes: 45 | ||
| steps: | ||
| - name: Checkout Playwright tests | ||
| uses: actions/checkout@v4 |
| }); | ||
| const commonEngine = new CommonEngine({ | ||
| enablePerformanceProfiler: environment.ssr.enablePerformanceProfiler, | ||
| allowedHosts: [ new URL(environment.ui.baseUrl).hostname, 'localhost', '127.0.0.1' ], |
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review