LINDAT/Make Solr heap tunable via SOLR_HEAP (backport #1309)#1331
Conversation
Backport of #1309 to customer/lindat. Translate (not cherry-pick) the single Solr heap line against this branch's actual compose file: it launches Solr with -p 8983, so only the -m 4g argument is changed to -m "${SOLR_HEAP:-4g}". With SOLR_HEAP unset the 4g default is preserved; AlwaysPreTouch no longer forces the full 4g commit when a smaller heap is set. Refs dataquest-dev/dspace-customers#746 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR closed due to redundancy - original PR (root/source) is made to dtq-dev -> which means lindat. |
Problem
The Solr heap in
docker/docker-compose-rest.ymlis hardcoded to-m 4g. With-XX:+AlwaysPreTouchthe container commits the full 4 GB on start — wasteful on shared devhosts running several DSpace stacks, and not lowerable without editing a tracked file.
Backport of #1309 to
customer/lindat.Tracking issue: dataquest-dev/dspace-customers#746
Change set
Single-line change to the
dspacesolrentrypoint indocker/docker-compose-rest.yml:Translated, not cherry-picked (per the FE backport model). On this branch (7.6.5 family) the Solr launch uses
-p 8983,so only the
-m 4gargument changed; the port and every other line are untouched. The valueis quoted to survive word-splitting, matching the source PR follow-up.
Out of scope: the default heap value (stays
4g), other services, ports, Solr image/version,and
AlwaysPreTouch.Test evidence
-m "${SOLR_HEAP:-4g}"-m 4gno longer present (grep count 0)yaml.safe_load); edit sits inside the entrypoint scalarSOLR_HEAPunset -> 4g,SOLR_HEAP=1g-> 1g