Skip to content

LINDAT/Make Solr heap tunable via SOLR_HEAP (backport #1309)#1331

Closed
jr-rk wants to merge 1 commit into
customer/lindatfrom
lindat/fe-tunable-solr-heap
Closed

LINDAT/Make Solr heap tunable via SOLR_HEAP (backport #1309)#1331
jr-rk wants to merge 1 commit into
customer/lindatfrom
lindat/fe-tunable-solr-heap

Conversation

@jr-rk

@jr-rk jr-rk commented Jun 25, 2026

Copy link
Copy Markdown

Problem

The Solr heap in docker/docker-compose-rest.yml is hardcoded to -m 4g. With
-XX:+AlwaysPreTouch the container commits the full 4 GB on start — wasteful on shared dev
hosts running several DSpace stacks, and not lowerable without editing a tracked file.

Backport of #1309 to customer/lindat.
Tracking issue: dataquest-dev/dspace-customers#746

Change set

Single-line change to the dspacesolr entrypoint in docker/docker-compose-rest.yml:

-      exec solr -p 8983 -f -m 4g
+      exec solr -p 8983 -f -m "${SOLR_HEAP:-4g}"

Translated, not cherry-picked (per the FE backport model). On this branch (7.6.5 family) the Solr launch uses -p 8983,
so only the -m 4g argument changed; the port and every other line are untouched. The value
is quoted to survive word-splitting, matching the source PR follow-up.

Out of scope: the default heap value (stays 4g), other services, ports, Solr image/version,
and AlwaysPreTouch.

Test evidence

  • Post-change marker present (line 178): -m "${SOLR_HEAP:-4g}"
  • Pre-change marker -m 4g no longer present (grep count 0)
  • Compose YAML re-parses cleanly (yaml.safe_load); edit sits inside the entrypoint scalar
  • Default/override: SOLR_HEAP unset -> 4g, SOLR_HEAP=1g -> 1g

Backport of #1309 to customer/lindat.
Translate (not cherry-pick) the single Solr heap line against this
branch's actual compose file: it launches Solr with -p 8983, so only the
-m 4g argument is changed to -m "${SOLR_HEAP:-4g}". With SOLR_HEAP
unset the 4g default is preserved; AlwaysPreTouch no longer forces the
full 4g commit when a smaller heap is set.

Refs dataquest-dev/dspace-customers#746

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 63fe041e-16b9-484d-aa60-3eef9c447e85

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jr-rk jr-rk self-assigned this Jun 25, 2026
@jr-rk jr-rk requested a review from milanmajchrak June 25, 2026 13:47
@jr-rk

jr-rk commented Jun 25, 2026

Copy link
Copy Markdown
Author

PR closed due to redundancy - original PR (root/source) is made to dtq-dev -> which means lindat.

@jr-rk jr-rk closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant