Skip to content

[Port to dtq-dev] add search icon to community and collection#1326

Open
kosarko wants to merge 1 commit into
dataquest-dev:dtq-devfrom
ufal:backport-109-to-dtq-dev
Open

[Port to dtq-dev] add search icon to community and collection#1326
kosarko wants to merge 1 commit into
dataquest-dev:dtq-devfrom
ufal:backport-109-to-dtq-dev

Conversation

@kosarko

@kosarko kosarko commented Jun 25, 2026

Copy link
Copy Markdown

Port of ufal#109 by @amadulhaxxani to dtq-dev.

Summary by CodeRabbit

  • New Features

    • Added a search link to community and collection page action menus, taking users directly to search results for that space.
    • Menu links now preserve additional navigation details when opened.
  • Tests

    • Added and updated unit tests to cover the new menu item and its link behavior.
    • Expanded page tests to confirm the edit menu appears in the header.

* add search icon to community and collection

add search icon to community and collection, click should navigate to community/collection pre-selected advance search page
add tests to confirm the new navigation

* Remove redundant wrapper div from collection/community page

Remove redundant wrapper div from collection/community page

(cherry picked from commit 385b33d)
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 41cbe3e6-34f9-461d-b66d-85665831bd2b

📥 Commits

Reviewing files that changed from the base of the PR and between 778d878 and 14f1949.

📒 Files selected for processing (6)
  • src/app/collection-page/collection-page.component.spec.ts
  • src/app/community-page/community-page.component.spec.ts
  • src/app/shared/dso-page/dso-edit-menu.resolver.spec.ts
  • src/app/shared/dso-page/dso-edit-menu.resolver.ts
  • src/app/shared/dso-page/dso-edit-menu/dso-edit-menu-section/dso-edit-menu-section.component.html
  • src/app/shared/dso-page/dso-edit-menu/dso-edit-menu-section/dso-edit-menu-section.component.spec.ts

📝 Walkthrough

Walkthrough

Adds a search-dso menu entry for communities and collections, passes query parameters through the edit-menu link template, and adds collection/community page specs that assert the header renders the edit menu.

Changes

DSO search menu flow

Layer / File(s) Summary
Search menu contract
src/app/shared/dso-page/dso-edit-menu.resolver.ts, src/app/shared/dso-page/dso-edit-menu.resolver.spec.ts
getComColMenu adds a search-dso link for communities and collections, and resolver specs cover the community, collection, and item cases.
Menu link query params
src/app/shared/dso-page/dso-edit-menu/dso-edit-menu-section/dso-edit-menu-section.component.html, src/app/shared/dso-page/dso-edit-menu/dso-edit-menu-section/dso-edit-menu-section.component.spec.ts
The menu section template binds itemModel.queryParams, and the section spec asserts the rendered link exposes the scope query parameter.
Header edit menu coverage
src/app/community-page/community-page.component.spec.ts, src/app/collection-page/collection-page.component.spec.ts
Collection and community page specs configure component test beds, stub ngOnInit, and assert that the header renders ds-dso-edit-menu.

Sequence Diagram(s)

sequenceDiagram
  participant DSOEditMenuResolver
  participant DsoEditMenuSectionComponent
  participant Router
  DSOEditMenuResolver->>DsoEditMenuSectionComponent: provides search-dso menu item
  DsoEditMenuSectionComponent->>Router: binds /search with spc.page=1 and scope
  Router-->>DsoEditMenuSectionComponent: navigates with the query params
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • milanmajchrak
  • vidiecan
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete and misses the required template sections like Problem description, Analysis, Problems, and testing/review checklists. Expand the PR description to follow the template and include the missing sections, especially problem description, analysis, problems, and relevant checklists.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: adding a search icon for community and collection pages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants