[Port to dtq-dev] add search icon to community and collection#1326
Open
kosarko wants to merge 1 commit into
Open
[Port to dtq-dev] add search icon to community and collection#1326kosarko wants to merge 1 commit into
kosarko wants to merge 1 commit into
Conversation
* add search icon to community and collection add search icon to community and collection, click should navigate to community/collection pre-selected advance search page add tests to confirm the new navigation * Remove redundant wrapper div from collection/community page Remove redundant wrapper div from collection/community page (cherry picked from commit 385b33d)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds a ChangesDSO search menu flow
Sequence Diagram(s)sequenceDiagram
participant DSOEditMenuResolver
participant DsoEditMenuSectionComponent
participant Router
DSOEditMenuResolver->>DsoEditMenuSectionComponent: provides search-dso menu item
DsoEditMenuSectionComponent->>Router: binds /search with spc.page=1 and scope
Router-->>DsoEditMenuSectionComponent: navigates with the query params
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of ufal#109 by @amadulhaxxani to
dtq-dev.Summary by CodeRabbit
New Features
Tests