VSB-TUO/Backport: Fix home-page SSR->CSR flicker#1320
Open
jr-rk wants to merge 2 commits into
Open
Conversation
Follow-up to the merged VSB-TUO flicker backport (#1288). The overlay remover bailed out via `if (!el) return;` before unhiding <ds-app>, so if the overlay node went missing (browser extension, race, external script) the app stayed visibility:hidden forever -> blank page, plus the kept SSR styles leaked. Unhide the app and clean up the kept styles unconditionally, before checking for the overlay node. This matches the guard already applied to the other customer backports. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…dule.ts The original VSB-TUO cherry-pick (#1288) left the dspace eager theme imported twice (as DSpaceEagerThemeModule and again, unaliased, as EagerThemeModule), with both listed in imports[]. Angular dedupes module imports so it was harmless, but it was cruft. Align the file with the other customer backports: dspace eager theme once + custom eager theme once. The custom theme stays eager (also keeps untyped-item theming working, ref DSpace#1897). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
A follow-up fix to the already-merged VSB-TUO flicker backport (#1288). That PR cherry-picked the original SSR->CSR flicker fix (#1287) onto
customer/vsb-tuobefore two later corrections existed. This PR brings VSB-TUO in line with the corrected version now shared across the other customer backports (#1310, #1311, #1312, #1314).Tracking issue: dataquest-dev/dspace-customers#717
Why it's needed (the "fixing" character)
#1288 shipped two latent issues that were found and fixed on the other instances afterwards:
Permanent blank-page risk (critical). The inline overlay remover in
src/index.htmlbailed out viaif (!el) return;before unhiding<ds-app>. If the overlay node ever goes missing (browser extension, race, another script), the real app staysvisibility:hiddenforever -> blank page, and the kept SSR styles leak. Fixed by always unhiding the app and cleaning the kept styles first, before checking for the overlay node.Duplicate eager-theme import (cleanup). The cherry-pick left
./dspace/eager-theme.moduleimported twice (asDSpaceEagerThemeModuleand again, unaliased, asEagerThemeModule), both inimports[]. Angular dedupes module imports so it was harmless, but it was cruft. Aligned to the canonical form used by the other backports: dspace eager theme once + custom eager theme once.What's intentionally NOT in this PR
VSB-TUO independently evolved its overlay-removal trigger (
removeSsrOverlayWhenContentVisible, keyed off!isAuthenticationBlocking && !isThemeLoading) which differs from theApplicationRef.isStabletrigger the other backports use. Deciding which trigger becomes canonical across all instances is a separate step and is out of scope here; this PR only brings over the two approach-independent fixes above.Related