Skip to content

MENDELU/fix: prevent orphaned items - abort leaked request Context (backport #1352 to mendelu) #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 2 commits into from
Jul 3, 2026
Merged

MENDELU/fix: prevent orphaned items - abort leaked request Context (backport #1352 to mendelu) #1357

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbc8d58
fix: abort leaked request Context in StatelessAuthenticationFilter (b…
milanmajchrak Jul 2, 2026
7f98910
docs: clarify Context-abort comment and link #1353 (Copilot review)
jr-rk Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ...rver-webapp/src/main/java/org/dspace/app/rest/security/StatelessAuthenticationFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,23 @@ protected void doFilterInternal(HttpServletRequest req,
if (authentication != null) {
SecurityContextHolder.getContext().setAuthentication(authentication);
}
chain.doFilter(req, res);

try {
chain.doFilter(req, res);
} finally {
// Abort the request-scoped DSpace Context if it is still open, so a leaked, dirty
// Hibernate session is not left bound to the worker thread (prevents orphaned items).
Comment thread
jr-rk marked this conversation as resolved.
// See https://github.com/dataquest-dev/DSpace/issues/1353
Context context = (Context) req.getAttribute(ContextUtil.DSPACE_CONTEXT);
// Ensure the context is cleared after the request is done
if (context != null && context.isValid()) {
try {
context.abort();
} catch (Exception e) {
log.error("{} occurred while trying to close", e.getMessage(), e);
}
Comment thread
jr-rk marked this conversation as resolved.
}
}
}

/**
Expand Down
Loading