Skip to content

ZCU-DATA/fix: prevent orphaned items — abort leaked request Context (backport dc57ffded8/#852 to zcu-data) #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 1 commit into from
Jul 2, 2026
Merged

ZCU-DATA/fix: prevent orphaned items — abort leaked request Context (backport dc57ffded8/#852 to zcu-data) #1352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ...rver-webapp/src/main/java/org/dspace/app/rest/security/StatelessAuthenticationFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,23 @@ protected void doFilterInternal(HttpServletRequest req,
if (authentication != null) {
SecurityContextHolder.getContext().setAuthentication(authentication);
}
chain.doFilter(req, res);

try {
chain.doFilter(req, res);
} finally {
// Complete the context to avoid transactions getting stuck in the connection pool in the
// `idle in transaction` state.
// TODO add the issue url
Context context = (Context) req.getAttribute(ContextUtil.DSPACE_CONTEXT);
// Ensure the context is cleared after the request is done
if (context != null && context.isValid()) {
try {
context.abort();
} catch (Exception e) {
log.error("{} occurred while trying to close", e.getMessage(), e);
}
}
}
}

/**
Expand Down
Loading