Skip to content

fix: NPE (HTTP 500) in CanManageMappingsFeature for item with null owning collection #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milanmajchrak wants to merge 1 commit into
base: dtq-dev
Choose a base branch
from
Open

fix: NPE (HTTP 500) in CanManageMappingsFeature for item with null owning collection #1348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...webapp/src/main/java/org/dspace/app/rest/authorization/impl/CanManageMappingsFeature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,18 @@ public boolean isAuthorized(Context context, BaseObjectRest object) throws SQLEx
}
if (object instanceof ItemRest) {
Item item = itemService.find(context, UUID.fromString(((ItemRest) object).getUuid()));
if (!authorizeService.authorizeActionBoolean(context, item, Constants.WRITE)) {
if (item == null || !authorizeService.authorizeActionBoolean(context, item, Constants.WRITE)) {
return false;
}
// An orphaned item (e.g. one whose owning collection was lost) has no owning collection.
// Guard against it so the feature evaluation does not throw a NullPointerException.
Comment on lines +67 to +71
Collection owningCollection = item.getOwningCollection();
try {
Optional<Collection> collections = collectionService.findCollectionsWithSubmit(StringUtils.EMPTY,
context, null, 0, Integer.MAX_VALUE)
.stream()
.filter(c -> !c.getID().equals(item.getOwningCollection().getID()))
.filter(c -> owningCollection == null
|| !c.getID().equals(owningCollection.getID()))
.filter(c -> {
try {
return collectionService.canEditBoolean(context, c);
Expand Down
Loading