New-DbaDbDataGeneratorConfig - Stop eating the caller loop on failures - #10647
Merged
potatoqualitee merged 1 commit intoSep 1, 2026
Merged
Conversation
Both guards called Stop-Function -Continue without an enclosing loop: the columntypes.json import guard in the begin block and the write-failure guard at the end of the process block. Without -EnableException the continue escaped the command and consumed an iteration of whatever loop the caller was running in. Both now stop and return. Part of the #10638 inventory. The write-failure path is pinned by a regression test that generates the config once, makes the target file read-only and loops three times over the then-failing write - red on the unfixed command with "Expected 3, but got 0". The import guard has no test because it only fires when the module's own shipped columntypes.json is missing, which cannot be triggered without corrupting the installation. References #10638 (do New-DbaDbDataGeneratorConfig) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
potatoqualitee
approved these changes
Aug 30, 2026
potatoqualitee
left a comment
potatoqualitee
left a comment
Member
There was a problem hiding this comment.
Reviewed the complete current head, both failure guards, regression coverage, and exact-head CI evidence. No material correctness or compatibility issues found.
potatoqualitee
deleted the
fix-newdbadbdatageneratorconfig-continue-escape
branch
September 1, 2026 05:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eleventh fix from the #10638 inventory. Both guards called
Stop-Function -Continuewithout an enclosing loop: the columntypes.json import guard in the begin block, and the write-failure guard at the tail of the process block. The escape ate an iteration of the caller's loop; both now stop andreturn.Tests
The write-failure path is pinned by a regression test that generates the config once, sets the target file read-only, and loops three times over the then-failing write: red on the unfixed command ("Expected 3, but got 0"), green on the fix (lab harness, environment clean). The import guard carries no test because it fires only when the module's own shipped
bin\datamasking\columntypes.jsonis missing - untriggerable without corrupting the installation, and the fix is the same two-line shape verified nine times in this series.References #10638
created by Claude and reviewed by Andreas Jordan
馃 Generated with Claude Code