Import-DbaBinaryFile - Stop eating the caller loop on FilePath validation - #10646
Open
andreasjordan wants to merge 1 commit into
Open
Import-DbaBinaryFile - Stop eating the caller loop on FilePath validation#10646andreasjordan wants to merge 1 commit into
andreasjordan wants to merge 1 commit into
Conversation
…tion The two FilePath guards called Stop-Function -Continue, but no loop encloses them: without -EnableException the continue escaped the command and consumed an iteration of whatever loop the caller was running in. The guards directly above (missing Path/FilePath, Path not a container) already stop and return - these two now do the same. Part of the #10638 inventory. Verified via the lab harness: all tests green including the connection-ownership contexts, lab left clean; the unfixed command fails the new loop-counter test with "Expected 3, but got 0". References #10638 (do Import-DbaBinaryFile) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
potatoqualitee
approved these changes
Aug 30, 2026
potatoqualitee
left a comment
potatoqualitee
left a comment
Member
There was a problem hiding this comment.
Reviewed the complete current head, both validation guards, regression coverage, and exact-head CI evidence. No material correctness or compatibility issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tenth fix from the #10638 inventory. The two
-FilePathguards (file missing, path is a directory) calledStop-Function -Continuewith no enclosing loop - the escape ate an iteration of the caller's loop. The guards directly above them already use the correct stop-and-returnform; these two now match.Tests
Loop-counter regression test over a nonexistent
-FilePath: red on the unfixed command ("Expected 3, but got 0"), green on the fix via the lab harness on SQL03\SQL2019, lab left clean.References #10638
created by Claude and reviewed by Andreas Jordan
🤖 Generated with Claude Code