Dm 3801 config library python client#33
Merged
Merged
Conversation
andrewchester-dm
assigned
AaronBarnes07 and
andrewchester-dm and unassigned
AaronBarnes07
andrewchester-dm
force-pushed
the
DM-3801-config-library-python-client
branch
from
ff668ab to
5f2bbee
Compare
cph-datamasque
requested changes
Jul 7, 2026
cph-datamasque
left a comment
cph-datamasque
left a comment
Collaborator
There was a problem hiding this comment.
Try to keep the APIs consistent with existing ones, e.g. the discovery config APIs require config_type to be explicitly specified, so DCL APIs should do the same thing.
Remove references to "archiving" and server-side code terms - those are proprietary implementation details.
…read-only fields, wording, version bump)
cph-datamasque
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiscoveryConfigLibraryClientmixin: list/iter, get, get-by-name (namespaced, exact), create, update, create-or-update, delete by id/name withforce.DiscoveryConfigLibrarymodel (discovery-config fields +namespace)./api/discovery/config-libraries/; no git methods (the client wraps none).