fix: sanitize carriage returns in test_parameters - #119
Open
Oluwajuwon-O wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
The production query change needs a regression test. Please add a case where otherwise-identical test_parameters differ only by a carriage return, and confirm get_configured_tests_row resolves the existing configured test. |
Oluwajuwon-O
marked this pull request as ready for review
August 6, 2026 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the carriage-return sanitization issue described in the technical documentation:
Cross-platform test_parameters matching failure
DOT could fail to match configured tests when
test_parameterscontained carriage returns (\r/\r\n). The regex comparison inget_configured_tests_row()treated otherwise-identical JSON payloads as different, so tests did not register successfully—especially when parameters were authored or transferred with Windows-style line endings.Resolution
test_parameterstext before comparison usingREPLACE(test_parameters::text, '\r', '').In the Technical Documentation, this is addressed in Section 6.6.
Asana Task
Deployment Readiness*
Testing
Describe or check:
Deployment Notes
Describe or check:
Rollback Plan
Describe or check:
git revert)Reviewer Guidance / Questions*
Screenshots / Testing Evidence*
SOC 2 Change Management Checklist
./vendor/bin/pest)Provide justification if you are submitting a PR with any boxes checked other than the first.
Reminder for Reviewers: By approving this PR you are confirming that you have reviewed the code for correctness, security, and compliance with our engineering and SOC 2 standards. Do not approve PRs where SOC 2 checklist items are checked without documented justification.
*Optional