Add ability to encrypt excel files [SC-SC-203035]#14
Draft
apichery wants to merge 2 commits into
Draft
Conversation
liamlynch-data
left a comment
Contributor
There was a problem hiding this comment.
Looks ok as far as it goes - the only thing is that the when the recipe config is saved the password is not encrypted (unlike everywhere else in DSS thanks to the other PR).
I think the easiest/best way to handle this is to add a preset config in the plugin (no DSS change required I think).
|
|
||
|
|
||
| def build_attachment_files(attachment_datasets, attachment_type, apply_coloring_excel): | ||
| def build_attachment_files(attachment_datasets, attachment_type, apply_coloring_excel, encryption_password_excel): |
Contributor
There was a problem hiding this comment.
need to add param to docstring
liamlynch-data
approved these changes
Sep 13, 2024
liamlynch-data
left a comment
Contributor
There was a problem hiding this comment.
I'm happy for this one to go in, ideally once we convert it to be able to use presets as done here:
#17
Contributor
|
We should wait for this feature to continue on this card. This will solve the security issues inherent in this approach without forcing the users to use presets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important - Requires this PR on the DSS side: https://github.com/dataiku/dip/pull/28735
Note: I couldn't find a way to have the "Encryption password" field appear only with DSS 13.0+.
If you know how to do it, here is simple method to plug