Add unit tests/linter with GitHub actions to run them on PR - #100
Open
vrutz wants to merge 11 commits into
Open
Conversation
…76--aks-eks-gke-add-ci-for-running-unit-tests
This reverts commit 2ee8a73.
pjestin-dku
requested changes
Aug 28, 2026
pjestin-dku
left a comment
pjestin-dku
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I see the linting and unit tests, as well as other checks are properly run.
There is only one format issue left, it's an extra newline in python-runnables/add-autoscaler/runnable.py. We should probably fix it so we have a ruff-clean repo. We can then make linting blocking, WDYT?
| continue-on-error: true | ||
| run: | | ||
| make lint || { | ||
| echo "::warning::Ruff lint/format checks failed. This is advisory for now; see the lint step logs." |
Contributor
There was a problem hiding this comment.
Why not make this step blocking?
The latest commit has a linting error, but it's not immediately visible, I needed to look in the action logs. I'm worried we will not pay attention and introducing new linting issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not need a release nor should it be in the release notes