feat: improve query parameter parsing for datafusion#326
Merged
Conversation
Member
sunng87
commented
Apr 10, 2026
sunng87
commented
- add data type coerce for various number type
- add parameter type support for numeric, this allows us to use uint64 and decimal for parameter
- allow coerce number to timestamp
mjgarton
reviewed
Apr 10, 2026
Collaborator
|
Looks good overall. I made a minor suggested simplification and here is a PR into your branch: #327 |
Instead of reusing `checked_int_cast` also for the float code paths and requiring a `source` parameter, split the int & float paths completely, making the callsites simpler, and reducing the overall code length.
mjgarton
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.