Implement Error Toasts#357
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a stacked Toaster notification system, adds zoom and tool Controls to the Atlas editor, updates the Button component to support multiple sizes, and introduces several new icons and color tokens. Feedback on these changes highlights critical issues: in toaster.tsx, the container height calculation when collapsed creates an invisible pointer-blocking area, and the heights state suffers from a memory leak as dismissed toast heights are never cleaned up. Additionally, in atlas.tsx, a CSS variable is incorrectly used for canvas rendering where static RGB values are required, and in button.tsx, making the new size prop required introduces a breaking change that should be resolved by making it optional with a default value.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
b1b8ab3 to
936ad05
Compare
nick-nlb
left a comment
There was a problem hiding this comment.
We can discuss the bigger comment and keep it for another PR, but otherwise the one smaller behavioral comment.
Do you mind also taking some screenshots and including them in the description here, and then pinging miss-o-soup to have a look (in case this is completely new UI/UX). Alternatively, since we're meeting tomorrow anyway, you could give it a demo then.
Overview
Adds a lightweight in-house toaster (foundations/toaster) based on Sonner.
type-headlinemixin, and a$z-index-toastertokenScreenshots