Skip to content

fix(dashboard): invalidate flag list with route website id #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r69shabh wants to merge 1 commit into
base: staging
Choose a base branch
from
+18 −5
Open

fix(dashboard): invalidate flag list with route website id #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions apps/dashboard/app/(main)/websites/[id]/flags/_components/flags-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ interface FlagsListProps {
stats: Map<string, FlagStats>;
statsError: boolean;
statsLoading: boolean;
websiteId: string;
}

const FLAG_LIST_MIN_WIDTH_CLASS = "min-w-[980px]";
Expand Down Expand Up @@ -77,7 +78,7 @@ function GroupsDisplay({ groups }: { groups: TargetGroup[] }) {
);
}

function StatusToggle({ flag }: { flag: Flag }) {
function StatusToggle({ flag, websiteId }: { flag: Flag; websiteId: string }) {
const queryClient = useQueryClient();
const isActive = flag.status === "active";

Expand All @@ -86,7 +87,7 @@ function StatusToggle({ flag }: { flag: Flag }) {
onSuccess: () => {
queryClient.invalidateQueries({
queryKey: orpc.flags.list.key({
input: { websiteId: flag.websiteId ?? "" },
input: { websiteId },
}),
});
},
Expand Down Expand Up @@ -126,10 +127,12 @@ function StatusToggle({ flag }: { flag: Flag }) {

function FlagActions({
flag,
websiteId,
onEdit,
onDelete,
}: {
flag: Flag;
websiteId: string;
onEdit: (flag: Flag) => void;
onDelete: (flagId: string) => void;
}) {
Expand All @@ -140,7 +143,7 @@ function FlagActions({
onSuccess: () => {
queryClient.invalidateQueries({
queryKey: orpc.flags.list.key({
input: { websiteId: flag.websiteId ?? "" },
input: { websiteId },
}),
});
},
Expand Down Expand Up @@ -405,6 +408,7 @@ function FlagRow({
statsLoading,
onEdit,
onDelete,
websiteId,
}: {
flag: Flag;
groups: TargetGroup[];
Expand All @@ -416,6 +420,7 @@ function FlagRow({
statsLoading: boolean;
onEdit: (flag: Flag) => void;
onDelete: (flagId: string) => void;
websiteId: string;
}) {
const typeConfig =
TYPE_CONFIG[flag.type as keyof typeof TYPE_CONFIG] ?? TYPE_CONFIG.boolean;
Expand Down Expand Up @@ -517,12 +522,17 @@ function FlagRow({
Archived
</Badge>
) : (
<StatusToggle flag={flag} />
<StatusToggle flag={flag} websiteId={websiteId} />
)}
</List.Cell>

<List.Cell action>
<FlagActions flag={flag} onDelete={onDelete} onEdit={onEdit} />
<FlagActions
flag={flag}
onDelete={onDelete}
onEdit={onEdit}
websiteId={websiteId}
/>
</List.Cell>
</List.Row>
);
Expand All @@ -531,6 +541,7 @@ function FlagRow({
export function FlagsList({
flags,
groups,
websiteId,
onRetryStats,
stats,
statsError,
Expand Down Expand Up @@ -576,6 +587,7 @@ export function FlagsList({
statsLoading={statsLoading}
onDelete={onDelete}
onEdit={onEdit}
websiteId={websiteId}
/>
))}
</List>
Expand Down
1 change: 1 addition & 0 deletions apps/dashboard/app/(main)/websites/[id]/flags/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ export default function FlagsPage() {
<FlagsList
flags={activeFlags as unknown as Flag[]}
groups={groupsMap}
websiteId={websiteId}
stats={statsMap}
statsError={flagStatsError}
statsLoading={flagStatsLoading}
Expand Down