Skip to content

fix(ai): allow public audience queries #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanskritisingh245 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

fix(ai): allow public audience queries #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/ai/src/query/builders/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ export const PUBLIC_QUERY_TYPES = new Set<string>([
"region",
"city",

// Public audience tab
"timezone",
"language",
"browser_versions",
"screen_resolution",

// Public product analytics tabs
"custom_events",
"custom_event_properties",
Expand Down
8 changes: 8 additions & 0 deletions packages/ai/src/query/builders/public-access.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ const PUBLIC_OVERVIEW_QUERY_TYPES = [
"country",
] as const;

const PUBLIC_AUDIENCE_QUERY_TYPES = [
"timezone",
"language",
"browser_versions",
"screen_resolution",
] as const;

const PUBLIC_EVENTS_QUERY_TYPES = [
"custom_events",
"custom_events_summary",
Expand Down Expand Up @@ -65,6 +72,7 @@ describe("query builder publicAccess", () => {
it("marks public dashboard query families as public-readable", () => {
const publicTypes = [
...PUBLIC_OVERVIEW_QUERY_TYPES,
...PUBLIC_AUDIENCE_QUERY_TYPES,
...PUBLIC_EVENTS_QUERY_TYPES,
...PUBLIC_ERROR_QUERY_TYPES,
...PUBLIC_VITALS_QUERY_TYPES,
Expand Down