Skip to content

fix(dashboard): correct appearance chart selects - #653

Open
akash3444 wants to merge 1 commit into
databuddy-analytics:stagingfrom
akash3444:fix/appearance-chart-selects
Open

fix(dashboard): correct appearance chart selects#653
akash3444 wants to merge 1 commit into
databuddy-analytics:stagingfrom
akash3444:fix/appearance-chart-selects

Conversation

@akash3444

@akash3444 akash3444 commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Show readable chart and style labels in Appearance settings.
  • Keep chart option icons and labels on one row.
  • Preserve existing Select behavior when items are not provided.

Before screenshots

image image

After screenshots

image image

Checks

  • bun run lint
  • bun run check-types

Summary by cubic

Fixes Appearance chart selects to show readable labels and keep icon + label on one line, improving clarity. Previously, options wrapped and trigger labels could be unclear; now selects use items with explicit labels, and Select preserves old behavior when items is omitted.

  • Dashboard: Pass items to chart type, step type, and location Selects and render options with a new ChartTypeOption that shows icon and label on one row.
  • UI Select: Provide the label registry only when items is undefined, avoiding conflicting labels when items is used; existing consumers without items are unaffected.

Written for commit 918b3fe. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

@akash3444 is attempting to deploy a commit to the Databuddy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fda63e44-2d6a-4655-bce4-28d81cb3ac38

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@akash3444
akash3444 marked this pull request as ready for review August 21, 2026 15:50
@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR corrects labels in the dashboard Appearance selects while preserving the legacy label-registry behavior for Select consumers that omit items.

  • Adds explicit label/value collections for chart type, curve type, and chart location selects.
  • Adds a reusable inline chart option renderer so icons and labels remain on one row.
  • Delegates selected-label rendering to Base Select when an items collection is supplied.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete functional, security, or repository-rule defects identified.

The supplied item collections cover every validated chart, curve, and location value, while Select consumers without items retain the existing custom label-registry path.

Important Files Changed

Filename Overview
apps/dashboard/app/(main)/settings/appearance/_components/chart-type-option.tsx Adds a small presentational component that renders a chart icon and label in one flex row.
apps/dashboard/app/(main)/settings/appearance/page.tsx Supplies complete readable-label collections to the appearance selects and reuses the inline chart option renderer.
packages/ui/src/components/select.tsx Uses the custom label registry only when Base Select is not given its own items collection.

Reviews (1): Last reviewed commit: "fix(dashboard): correct appearance chart..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant