fix(dashboard): correct appearance chart selects - #653
Conversation
|
@akash3444 is attempting to deploy a commit to the Databuddy OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR corrects labels in the dashboard Appearance selects while preserving the legacy label-registry behavior for Select consumers that omit
Confidence Score: 5/5The PR appears safe to merge, with no concrete functional, security, or repository-rule defects identified. The supplied item collections cover every validated chart, curve, and location value, while Select consumers without items retain the existing custom label-registry path. Important Files Changed
Reviews (1): Last reviewed commit: "fix(dashboard): correct appearance chart..." | Re-trigger Greptile |
Summary
itemsare not provided.Before screenshots
After screenshots
Checks
bun run lintbun run check-typesSummary by cubic
Fixes Appearance chart selects to show readable labels and keep icon + label on one line, improving clarity. Previously, options wrapped and trigger labels could be unclear; now selects use
itemswith explicit labels, andSelectpreserves old behavior whenitemsis omitted.itemsto chart type, step type, and locationSelects and render options with a newChartTypeOptionthat shows icon and label on one row.Select: Provide the label registry only whenitemsis undefined, avoiding conflicting labels whenitemsis used; existing consumers withoutitemsare unaffected.Written for commit 918b3fe. Summary will update on new commits.