Skip to content

fix(dashboard): align web vitals breakdown values #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akash3444 wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

fix(dashboard): align web vitals breakdown values #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .../(main)/websites/[id]/_components/tabs/performance/_components/web-vitals-metric-cell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,15 +65,22 @@ export function WebVitalsMetricCell({
const formatted =
metric === "cls" ? value.toFixed(3) : formatPerformanceTime(value);
const { colorClass, isGood, isPoor } = getMetricStyles(value, metric);
const showIcon = isGood || isPoor;

return (
<div className="flex items-center gap-1">
<div className="flex items-center justify-end gap-1">
{isGood ? (
<CheckCircle
aria-hidden="true"
className="size-3.5 shrink-0 text-success"
/>
) : null}
{isPoor ? (
<Warning
aria-hidden="true"
className="size-3.5 shrink-0 text-destructive"
/>
) : null}
<span className={colorClass}>{formatted}</span>
{showIcon && isGood && (
<CheckCircle className="size-3.5 text-green-600" />
)}
{showIcon && isPoor && <Warning className="size-3.5 text-red-600" />}
</div>
);
}
2 changes: 1 addition & 1 deletion apps/dashboard/components/table/table-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const DEFAULT_CELL_STYLE = {

const COMPACT_COLUMN_WIDTHS: Record<string, number> = {
clicks: 88,
cls: 76,
cls: 78,
current_time: 108,
customers: 100,
fcp: 88,
Expand Down
Loading