fix(dev): build devtools before dashboard dev startup - #644
Conversation
|
@MiirzaBaig is attempting to deploy a commit to the Databuddy OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdds the devtools build as a prerequisite of the root Turbo development task so fresh-checkout dashboard startup can resolve the package’s generated React export.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "fix(dev): build devtools before dashboar..." | Re-trigger Greptile |
Description
Adds
@databuddy/devtools#buildto the root Turbodevtask dependencies sobun run dev:dashboardprepares the dashboard@databuddy/devtools/reactimport on a fresh checkout.Closes #643
Slice
Verification
turbo.jsonJSON parse sanity check passed.packages/devtools/distout of the checkout, then ranbun run dev:dashboard.@databuddy/devtools:buildbefore starting the dashboard.curl -sI http://localhost:3000/loginreturnedHTTP/1.1 200 OK.Note: the repo pre-push hook ran the full
bun run testsuite and failed in existing SDK/tracker timer tests withjest.isFakeTimers is not a function/jest.advanceTimersByTime is not a function. This change only touchesturbo.json; targeted verification passed.Disclosure: I used AI assistance during repo inspection and PR drafting. I manually reproduced and verified the fix locally.
Checklist
stagingand does not include another unmerged PR unless it is named above.staging; after it closes, this branch will not be reused for another change.Summary by cubic
Builds
@databuddy/devtoolsbefore starting the dashboard dev server to fix fresh-checkout startup. Previouslybun run dev:dashboardcould fail on the@databuddy/devtools/reactimport; now Turbo runs@databuddy/devtools#buildas part of the rootdevtask. Addresses #643.turbo.json: add@databuddy/devtools#buildtodev.dependsOn(alongside@databuddy/sdk#build).devstart may take longer; no production behavior change.bun run dev:dashboardas usual.Written for commit b65f41d. Summary will update on new commits.