Skip to content

fix(dev): build devtools before dashboard dev startup - #644

Open
MiirzaBaig wants to merge 1 commit into
databuddy-analytics:stagingfrom
MiirzaBaig:fix/devtools-dev-build
Open

fix(dev): build devtools before dashboard dev startup#644
MiirzaBaig wants to merge 1 commit into
databuddy-analytics:stagingfrom
MiirzaBaig:fix/devtools-dev-build

Conversation

@MiirzaBaig

@MiirzaBaig MiirzaBaig commented Aug 21, 2026

Copy link
Copy Markdown

Description

Adds @databuddy/devtools#build to the root Turbo dev task dependencies so bun run dev:dashboard prepares the dashboard @databuddy/devtools/react import on a fresh checkout.

Closes #643

Slice

Verification

  • turbo.json JSON parse sanity check passed.
  • Moved packages/devtools/dist out of the checkout, then ran bun run dev:dashboard.
  • Confirmed Turbo ran @databuddy/devtools:build before starting the dashboard.
  • Confirmed curl -sI http://localhost:3000/login returned HTTP/1.1 200 OK.

Note: the repo pre-push hook ran the full bun run test suite and failed in existing SDK/tracker timer tests with jest.isFakeTimers is not a function / jest.advanceTimersByTime is not a function. This change only touches turbo.json; targeted verification passed.

Disclosure: I used AI assistance during repo inspection and PR drafting. I manually reproduced and verified the fix locally.

Checklist
  • This branch started from current staging and does not include another unmerged PR unless it is named above.
  • This is one independently reviewable slice; unrelated cleanup or refactors are in separate PRs.
  • I checked open PRs for overlapping files, contracts, schemas, or deployment configuration and made any dependency explicit above.
  • This PR targets staging; after it closes, this branch will not be reused for another change.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by cubic

Builds @databuddy/devtools before starting the dashboard dev server to fix fresh-checkout startup. Previously bun run dev:dashboard could fail on the @databuddy/devtools/react import; now Turbo runs @databuddy/devtools#build as part of the root dev task. Addresses #643.

  • Change in turbo.json: add @databuddy/devtools#build to dev.dependsOn (alongside @databuddy/sdk#build).
  • Dev-only impact: first dev start may take longer; no production behavior change.
  • Migration: none. Run bun run dev:dashboard as usual.

Written for commit b65f41d. Summary will update on new commits.

Review in cubic

@vercel

vercel Bot commented Aug 21, 2026

Copy link
Copy Markdown

@MiirzaBaig is attempting to deploy a commit to the Databuddy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f40a4ba5-2c49-4c1d-82c5-3566395fe50b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds the devtools build as a prerequisite of the root Turbo development task so fresh-checkout dashboard startup can resolve the package’s generated React export.

  • Builds @databuddy/devtools before persistent development tasks start.
  • Follows the existing prerequisite pattern used for @databuddy/sdk.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
turbo.json Adds a valid finite devtools build prerequisite to the persistent development task, with no blocking issue identified.

Reviews (2): Last reviewed commit: "fix(dev): build devtools before dashboar..." | Re-trigger Greptile

@izadoesdev
izadoesdev deleted the branch databuddy-analytics:staging August 21, 2026 09:05
@izadoesdev izadoesdev closed this Aug 21, 2026
@izadoesdev izadoesdev reopened this Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants