Skip to content

[superlog] Downgrade ClickHouse timeout log from ERROR to WARN in tracking health checks #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superlog-app wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[superlog] Downgrade ClickHouse timeout log from ERROR to WARN in tracking health checks #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/rpc/src/routers/websites.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,12 @@ async function getTrackingEventsStatus(
} catch (error) {
const message =
error instanceof Error ? error.message : "Unknown error checking events";
logger.error({ websiteId }, `Error checking tracking events: ${message}`);
const isTimeout = message === "ClickHouse query timeout";
if (isTimeout) {
logger.warn({ websiteId }, `Slow ClickHouse query checking tracking events: ${message}`);
} else {
logger.error({ websiteId }, `Error checking tracking events: ${message}`);
}
return { hasEvents: false, recentEvents: 0, error: message };
}
}
Expand Down Expand Up @@ -254,7 +259,12 @@ async function getRecentBlockedTrackingIssue(
error instanceof Error
? error.message
: "Unknown error checking blocked traffic";
logger.error({ websiteId }, `Error checking blocked traffic: ${message}`);
const isTimeout = message === "ClickHouse query timeout";
if (isTimeout) {
logger.warn({ websiteId }, `Slow ClickHouse query checking blocked traffic: ${message}`);
} else {
logger.error({ websiteId }, `Error checking blocked traffic: ${message}`);
}
return null;
}
}
Expand Down
Loading