Skip to content

[TECH DEBT] Update Dashboard.create_dashboard signature to match the LakeviewAPI.create/update signatures #322

Description

@JCZuurmond

The Python SDK v0.37.0 updated the LakeviewAPI.create/update signature to expect a Dashboard object. We can update our lsql Dashboard.create_dashboard with similar changes:

def create_dashboard(
self,
dashboard_metadata: DashboardMetadata,
*,
parent_path: str | None = None,
dashboard_id: str | None = None,
warehouse_id: str | None = None,
publish: bool = False,
) -> SDKDashboard:

becomes:

    def create_dashboard(
        self,
        dashboard_metadata: DashboardMetadata,
        *,
        dashboard: SDKDashboard=None,
        publish: bool = False,
    ) -> SDKDashboard:

Use deprecation warnings to incrementally introduce this signature change

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions