Repository navigation
Run lint in separate CI step instead of pytest - #803
Merged
Merged
Conversation
Linting previously ran through `tests/test_lint.py`, so a formatting or type error surfaced as a "Unit tests" failure rather than a lint failure. Move linting into a dedicated CI `Lint` job that runs `just lint`, and add a justfile whose `lint` recipe is the single source of truth for the gate (ruff check + ruff format --check + ty). Local and CI now run the identical recipe. `just fix` autofixes. Drop the now-redundant lint tests. The unit, e2e, and integration test jobs `needs: lint`, so a lint failure skips them and blocks the merge via the existing required-* gates (and avoids spending runner time on the e2e matrix when lint is red). Co-authored-by: Isaac <no-reply@databricks.com>
max-rozen-oss-db
force-pushed
the
add-lint-justfile
branch
from
September 23, 2026 01:54
41bafe3 to
d960972
Compare
Pin ruff==0.16.5 and ty==0.0.75 (the versions already resolved) in the dev dependency group. Both tools' output shifts between releases, so a floating version means local and CI can disagree about what "passes" the lint gate; pinning keeps them identical and makes bumps intentional, reviewable changes. Edit only the two matching specifiers in uv.lock — the resolved versions are unchanged, so this avoids the unrelated re-resolution churn a full `uv lock` would pull in from pre-existing lockfile drift. Co-authored-by: Isaac <no-reply@databricks.com>
max-rozen-oss-db
marked this pull request as ready for review
September 23, 2026 02:07
max-rozen-oss-db
requested review from
AarushiShah-db,
lilly-luo and
rohita5l
as code owners
September 23, 2026 02:07
max-rozen-oss-db
changed the title
just lint gate and run it in CI instead of via pytest
max-rozen-oss-db
enabled auto-merge (squash)
September 24, 2026 16:26
lilly-luo
reviewed
Sep 25, 2026
lilly-luo
reviewed
Sep 25, 2026
lilly-luo
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, the whole test run can fail due to lint errors. Instead run lint (ruff/ty) in a separate job. Tests run only after lint passes so you get faster fedback. Pin ruff and ty. Add a
justfileto run lint locally viajust; gha runs the same file.