Skip to content

Reject launch source flags under managed config - #714

Open
andy-xu-db wants to merge 4 commits into
mainfrom
andy-xu-db/stack/andy/managed-config-cli-guard
Open

andy-xu-db wants to merge 4 commits into
mainfrom
andy-xu-db/stack/andy/managed-config-cli-guard

Conversation

@andy-xu-db

@andy-xu-db andy-xu-db commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

🥞 Stacked PR

Use this link to review incremental changes.


Summary

  • Reject explicit --provider and --model-location launch options whenever the workspace returns a managed config, including an empty config.
  • Keep the existing first-launch/bootstrap path unchanged.
  • Keep saved provider choices valid; only explicit command-line source flags are rejected.

Stack

Built directly on #710. Claude behavior is isolated in #715 and Codex behavior in #716.

Testing

  • uv run pytest -q --ignore=tests/test_e2e_user_agent.py: 2,406 passed, 41 skipped at the stack tip
  • uv run pytest tests/test_cli.py -q: 369 passed on this branch
  • Ruff check and format check pass for all changed Python files
  • git diff --check

@lilly-luo

Copy link
Copy Markdown
Collaborator

this diff looks pretty extensive to do validation. would you be able to simplify some of the refactors + clean up the tests

@andy-xu-db
andy-xu-db force-pushed the andy-xu-db/stack/andy/managed-config-cli-guard branch from 32b156b to 98a11d2 Compare September 17, 2026 23:38
@andy-xu-db
andy-xu-db force-pushed the andy-xu-db/stack/andy/managed-config-cli-guard branch from 98a11d2 to 6b3d9ec Compare September 18, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants