Reject launch source flags under managed config - #714
Open
andy-xu-db wants to merge 4 commits into
Open
andy-xu-db wants to merge 4 commits into
andy-xu-db wants to merge 4 commits into
Conversation
This was referenced Sep 17, 2026
andy-xu-db
force-pushed
the
andy-xu-db/stack/andy/managed-config-cli-guard
branch
from
September 17, 2026 22:50
95c05ea to
32b156b
Compare
Collaborator
|
this diff looks pretty extensive to do validation. would you be able to simplify some of the refactors + clean up the tests |
andy-xu-db
force-pushed
the
andy-xu-db/stack/andy/managed-config-cli-guard
branch
from
September 17, 2026 23:38
32b156b to
98a11d2
Compare
andy-xu-db
force-pushed
the
andy-xu-db/stack/andy/managed-config-cli-guard
branch
from
September 18, 2026 04:35
98a11d2 to
6b3d9ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Summary
--providerand--model-locationlaunch options whenever the workspace returns a managed config, including an empty config.Stack
Built directly on #710. Claude behavior is isolated in #715 and Codex behavior in #716.
Testing
uv run pytest -q --ignore=tests/test_e2e_user_agent.py: 2,406 passed, 41 skipped at the stack tipuv run pytest tests/test_cli.py -q: 369 passed on this branchgit diff --check