perf: speed up constant string joins#825
Open
He-Pin wants to merge 1 commit intodatabricks:masterfrom
Open
Conversation
7dd77cb to
9e7c7f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std.makeArray(... literal)arrays as an O(1) constant array view.std.joinover constant/repeated string arrays with exactStringBuildersizing.private[this]in touched Scala sources.Benchmarks
Baseline:
upstream/master(04e5707c). This PR:7dd77cb7.Full JMH sweep was run on both sides with
./mill -i bench.runRegressions. Only the standout result is listed here.bench/resources/cpp_suite/large_string_join.jsonnetGC profiler for the same benchmark:
gc.alloc.rate.normScala Native hyperfine (
--shell=none --warmup 5 --runs 50, output via-o /dev/null):This narrows the
large_string_joinScala Native gap to jrsonnet from ~1.45x slower to ~1.15x slower.Validation
./mill -i __.checkFormatgit diff --check./mill -i 'sjsonnet.jvm[3.3.7].test'./mill -i 'sjsonnet.js[3.3.7].test'./mill -i 'sjsonnet.js[3.3.7].compile' 'sjsonnet.native[3.3.7].compile'./mill -i 'sjsonnet.native[3.3.7].nativeLink'