Skip to content

Fix: Ensure that in incremental strategies columns are backquoted appropriately#1595

Open
ash2shukla wants to merge 8 commits into
databricks:mainfrom
ash2shukla:allow-nonascii-in-columns
Open

Fix: Ensure that in incremental strategies columns are backquoted appropriately#1595
ash2shukla wants to merge 8 commits into
databricks:mainfrom
ash2shukla:allow-nonascii-in-columns

Conversation

@ash2shukla

Copy link
Copy Markdown

Resolves #1594

Description

  • Ensures that in incremental strategies columns are backquoted appropriately
  • Change the relevant macros to use adapter.quote

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.
  • [Optional] I have run /dbt-databricks-pr-ready (AI agent skill in .claude/skills/) and addressed its merge-readiness feedback

@sd-db sd-db changed the title Ensure that in incremental strategies columns are backquoted appropriately Fix: Ensure that in incremental strategies columns are backquoted appropriately Jul 17, 2026

@sd-db sd-db left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look goo, have commented on a minor test scope increase. Tests are good as is as well but this will make the coverage complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incremental strategies generate unquoted column identifiers, breaking non-ASCII column names on the second run with INVALID_IDENTIFIER

2 participants