fix: ignore server-set delta.parquet.compression.codec tblproperty#1489
Merged
Conversation
The backend began stamping delta.parquet.compression.codec=zstd onto streaming tables (and materialized views), which is not user-configurable. Because it was absent from TblPropertiesConfig.ignore_list, the relation config diff surfaced it and the exact-equality assertions in the streaming_tables change tests failed fleet-wide starting 2026-05-28. Add the property to ignore_list so it is dropped during config comparison, matching the existing pattern for other Databricks-set properties.
sd-db
force-pushed
the
sd-db/fix/st-zstd-compression-codec-ignore
branch
from
204a1ea to
2906484
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
jprakash-db
approved these changes
May 29, 2026
Collaborator
Author
|
/integration-test |
|
Integration tests dispatched for PR #1489 by @sd-db. Track progress in the Actions tab. |
|
Integration results for PR #1489 — UC cluster ❌ failure · SQL warehouse ❌ failure · All-purpose cluster ❌ failure · Shard coverage ✅ success |
Collaborator
Author
|
Integration run looks okay, the issue at hand is fixed. There is a single failing test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A recent server-side change began stamping the non-user-configurable property
delta.parquet.compression.codec=zstdonto streaming tables and materialized views. Because it was absent fromTblPropertiesConfig.ignore_list, it leaked into the existing-relation config but never the desired (model) config — soget_changesetreported a phantom configuration change on every run of an otherwise-unchanged relation.Impact by
on_configuration_change:fail→ idempotentdbt runs now error out (regression)apply→ spuriousALTER … SET TBLPROPERTIESevery runcontinue→ spurious "configuration changes were identified" warning every runThis surfaced fleet-wide on 2026-05-28 (both
mainnightly and feature-branch CI); the same tests passed on 2026-05-27 with no intervening code change, pinning the cause to the backend.Fix
Add
delta.parquet.compression.codectoTblPropertiesConfig.ignore_listso it is dropped during config comparison, matching the existing pattern for other Databricks-set properties (e.g.delta.enableDeletionVectors,delta.columnMapping.maxColumnId).Testing
test_from_results__drops_ignored_propertiesto lock the filter behavior; full unit suite passes (1116 passed).TestStreamingTableChangesApply::test_change_is_applied_via_alterpasses against a live SQL warehouse (was failing in CI). The other 6 failures — includingtest_idempotent_run_does_not_fail, which exercises the regression directly — route through the same comparison and are covered by the same filter.