-
Notifications
You must be signed in to change notification settings - Fork 64
feat(kernel): SEA-via-kernel PuPr tail: advanced proxy, Geography, conn/error telemetry, token-caching docs, configurable backoff #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mani-mathur-arch
wants to merge
13
commits into
main
Choose a base branch
from
mani/sea-kernel-new-items
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
46ee830
feat(kernel): advanced HTTP proxy via WithKernelProxy
mani-mathur-arch 4fc162d
test(kernel): cover Geography as the WKT sibling of Geometry
mani-mathur-arch 91bb066
feat(kernel): emit connection-config telemetry + fix connection-scope…
mani-mathur-arch de66735
docs(kernel): note token caching + client reuse are inherited from th…
mani-mathur-arch 6c579ee
feat(kernel): configurable HTTP retry / backoff via WithRetries
mani-mathur-arch 3f90ce3
fix(lint): suppress gosec G101 false positives on test/enum literals
mani-mathur-arch 905ceae
feat(kernel): report column-type metadata on the kernel Rows path
mani-mathur-arch a63f98a
perf(decimal): alloc-free exact decimal renderer (shared Thrift + ker…
mani-mathur-arch 1cff39c
feat(kernel): tune CloudFetch in-memory chunks via WithKernelMaxChunk…
mani-mathur-arch 29edbba
fix(kernel): address code-review findings — retry drop, rejection msg…
mani-mathur-arch d705eda
build(kernel): re-pin KERNEL_REV to retry/backoff PR head (#178)
mani-mathur-arch bd84ae8
fix(kernel): address 2nd-round review — retry-config edge cases, prox…
mani-mathur-arch c72a136
feat(kernel): log + emit telemetry for the resolved retry policy and …
mani-mathur-arch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 4d301455f7e70de9cb747e0f1143b8a3df8c5b48 | ||
| f29957733c8f6d79a7212bc8a50cf4e5ffa8dd69 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Medium]
KERNEL_REVpins an unmerged PR-branch head → non-reproducible / breakable CIf299577…is the head of kernel PR #178 (OPEN). The required symbols (set_retry_config,apply_client_result_overrides) exist only on that branch, not kernelmain(verified). A PR head is a mutable ref: a squash-merge / rebase / force-push moves it and GitHub GCs the orphaned commit, after which the kernel-lib fetch ofrefs/pull/*/headcan no longer reach this SHA and every cold (cache-miss) CI build goes red with no source change here.The PR body already commits to re-pinning to the squash-merge SHA once #178 lands — this should block merge, and ideally #178 merges first so the pin points at a
maincommit.Posted by code-review-squad ·
/full-review· feedback:#code-review-squad-feedbackThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is already called out in the pr description. This will be taken care of while merging.