[air] Upload the finalized training config - #6611
Open
caroline-db wants to merge 2 commits into
Open
Conversation
Collaborator
Integration test reportCommit: 0d5d7b4
Top 3 slowest tests (at least 2 minutes):
|
caroline-db
force-pushed
the
air-final-training-config
branch
2 times, most recently
from
September 11, 2026 15:51
4a7db4e to
af92b8d
Compare
caroline-db
force-pushed
the
air-final-training-config
branch
from
September 11, 2026 17:11
af92b8d to
0d5d7b4
Compare
caroline-db
marked this pull request as ready for review
September 11, 2026 19:10
Contributor
Approval status: pending
|
caroline-db
requested review from
ben-hansen-db and
maggiewang-db
and removed request for
maggiewang-db
September 14, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you change, and why?
buildArtifactsreread the original YAML when creatingtraining_config.yaml. The submitted workload used the overridden configuration while the uploaded artifact andair getstill showed the original values.training_config.yaml. The separately decoded configuration remains responsible for validation, normalization, and API submission.How do you know it works?
go test ./experimental/air/cmdgo test ./acceptance -run TestAccept/experimental/air/run-submit-overrides$ -tail -test.v./task fmt-q./task lint-q./task checks./task testair getdisplays the overridden nested value.