Simplify aitools install output and default the confirm to yes#5916
Open
lennartkats-db wants to merge 2 commits into
Open
Simplify aitools install output and default the confirm to yes#5916lennartkats-db wants to merge 2 commits into
lennartkats-db wants to merge 2 commits into
Conversation
The `databricks aitools install` output was intimidating: a `Proceed? [y/N]` prompt that defaulted to no, followed by ~57 lines of per-skill `Downloading X` / `Exposing X to N agents` progress plus a self-contradictory "run 'databricks aitools install' to refresh" legacy message. - Confirm now uses a huh confirm defaulting to yes (matching the huh agent picker shown right above it), so Enter proceeds. - Collapse the per-skill download/expose lines into a single cmdio spinner, scoped to the install loop so earlier warnings still print as plain lines. The same spinner is used in the update path. - Drop the contradictory legacy-refresh message during a full install; legacy detection still blocks targeted installs and rebuilds state on a full run. - Remove the now-unused checkLegacyInstall and agentNoun helpers. Co-authored-by: Isaac
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Drop the redundant doc comment on defaultPromptProceed (the code is self-explanatory) and add a one-line pointer to where hasLegacyInstall lives. Co-authored-by: Isaac
lennartkats-db
commented
Jul 13, 2026
|
|
||
| // checkLegacyInstall prints a message if skills exist on disk but no state file was found. | ||
| // Returns true if a legacy install was detected. | ||
| func checkLegacyInstall(ctx context.Context, globalDir string) bool { |
Contributor
Author
There was a problem hiding this comment.
FYA, this function was removed in favor of reusing the one at
cli/libs/aitools/installer/update.go
Line 272 in ee76df3
lennartkats-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
approved these changes
Jul 14, 2026
| } | ||
| } | ||
|
|
||
| func defaultPromptProceed(_ context.Context) (bool, error) { |
Contributor
There was a problem hiding this comment.
Can we remove the context given that it is ignored? It does not seem this function needs to comply with a specific signature.
Suggested change
| func defaultPromptProceed(_ context.Context) (bool, error) { | |
| func defaultPromptProceed() (bool, error) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
databricks aitools installwas a bit of a wall of text with, and its confirmation defaulted to no. This trims it down.Before (~60 lines):
After:
Tests
Unit + acceptance tests updated; verified over a real terminal (Enter proceeds,
ncancels, output collapses to one spinner).