databricks experimental open: emit ?w= URL query parameter#5369
Open
Divyansh-db wants to merge 1 commit into
Open
databricks experimental open: emit ?w= URL query parameter#5369Divyansh-db wants to merge 1 commit into
Divyansh-db wants to merge 1 commit into
Conversation
The Databricks UI is migrating from ?o=<workspace-id> to ?w=<workspace-id> as the SPOG URL query parameter, matching the recent workspace addressing header rename. Switch BuildResourceURL in libs/workspaceurls to write ?w= when appending the workspace identifier. This affects URLs printed by databricks experimental open. The legacy ?o= URL spelling remains a valid input wherever the CLI parses host URLs; only the emitted form changes. bundle/config/mutator/initialize_urls.go also adds a workspace identifier query parameter, but it does so before calling ResourceURL with an already-built baseURL, so this change does not affect bundle output.
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Databricks UI is migrating from
?o=<workspace-id>to?w=<workspace-id>as the SPOG URL query parameter, matching the recent workspace addressing header rename. This PR switchesBuildResourceURLinlibs/workspaceurlsto write?w=when appending the workspace identifier.This affects URLs printed by
databricks experimental open. The legacy?o=URL spelling remains a valid input anywhere the CLI parses host URLs; only the emitted form changes.Scope
libs/workspaceurls/urls.go—workspaceBaseURLnow addsw=<id>, docstring onBuildResourceURLupdated.libs/workspaceurls/urls_test.go— expected URLs flipped.cmd/experimental/workspace_open_test.go— expected URLs flipped.acceptance/experimental/open/output.txt— regenerated via./task test-update.bundle/config/mutator/initialize_urls.goalso adds a workspace identifier query parameter, but it does so before callingResourceURLwith an already-built baseURL, so this change does not affect bundle output. The bundle path can flip in a separate change.Test plan
go test ./libs/workspaceurls/... ./cmd/experimental/...— greengo test ./acceptance -run 'TestAccept/experimental/open'— green (golden file regenerated)./task lint-q— 0 issues;./task fmt— no changes