Added support for lifecycle.started for SQL warehouses#5348
Open
andrewnester wants to merge 1 commit into
Open
Added support for lifecycle.started for SQL warehouses#5348andrewnester wants to merge 1 commit into
andrewnester wants to merge 1 commit into
Conversation
andrewnester
requested review from
denik,
janniklasrose,
pietern and
shreyas-goenka
Contributor
Approval status: pending
|
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 0af4cd1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added support for lifecycle.started for SQL warehouses
Why
Without this field, warehouses defined in a bundle are always left in whatever state the API puts them in after creation.
Users have no way to declare "ensure this sql warehouse is running after every deploy."
lifecycle.started: true guarantees the warehouse is RUNNING after bundle deploy.
lifecycle.started: false creates the warehouse but immediately terminates it, and subsequent deploys that detect drift (e.g., someone started the warehouse manually) will stop it again.
Tests
Added acceptance tests