build(deps): bump golang.org/x/crypto from 0.51.0 to 0.52.0#5344
Open
shreyas-goenka wants to merge 2 commits into
Open
build(deps): bump golang.org/x/crypto from 0.51.0 to 0.52.0#5344shreyas-goenka wants to merge 2 commits into
shreyas-goenka wants to merge 2 commits into
Conversation
Addresses CVE-2026-39827 in golang.org/x/crypto/ssh server code (memory exhaustion via rejected channels). The CLI does not run an SSH server, so this is not exploitable here, but a customer security scanner flags the binary regardless. Bumping unblocks them. Transitively bumps golang.org/x/net 0.53.0 -> 0.54.0 and golang.org/x/sys 0.44.0 -> 0.45.0 via go mod tidy. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
|
Commit: 71eedf9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
golang.org/x/cryptofrom 0.51.0 to 0.52.0 to address CVE-2026-39827 (CVSS 6.5).go mod tidytransitively bumpsgolang.org/x/net0.53.0 -> 0.54.0 andgolang.org/x/sys0.44.0 -> 0.45.0.Context
The CVE is in
golang.org/x/crypto/sshserver code (memory exhaustion via repeatedly rejected channels by an authenticated client) — the CLI does not run an SSH server, so it is not exploitable here. We only usessh.NewPublicKey/ssh.MarshalAuthorizedKeyinexperimental/ssh/internal/keys/keys.go. Bumping anyway to clear the CVE scanners.0.52.0 known issues check
One open issue against v0.52.0: golang/go#79658 — spinloop in
x/crypto/ssh(*channel).SendRequest. We do not call into SSH channels, so this does not affect the CLI.Test plan
./task buildgo test ./experimental/ssh/...(only place we usex/crypto)This pull request and its description were written by Isaac.