Treat deleted resources as not running in fail-on-active-runs check#5044
Merged
Treat deleted resources as not running in fail-on-active-runs check#5044
Conversation
Follow-up to #4997, which enabled nilerr and annotated the pipeline branch of `checkAnyResourceRunning` with `//nolint:nilerr`. Instead of suppressing the finding, handle deleted resources explicitly: - Use `apierr.IsMissing` in `IsJobRunning` and `IsPipelineRunning` so a 404 maps to "not running" rather than an error. - Propagate genuine API errors from the pipeline branch instead of swallowing them. Co-authored-by: Isaac
pietern
requested review from
andrewnester and
denik
and removed request for
andrewnester
denik
approved these changes
Apr 21, 2026
bernardo-rodriguez
pushed a commit
to bernardo-rodriguez/b-cli
that referenced
this pull request
Apr 22, 2026
## Summary - Add Lakebase destroy/recreate prompt (databricks#5052) and fail-on-active-runs deleted-resource fix (databricks#5044) to the Bundles section. - Note the `jobs list` / `jobs list-runs` `--page-size` rename that came with the repo-wide `--limit` flag from the SDK v0.127.0 bump. - Attribute the Apps update-mask change to databricks#5042 and databricks#5051 (the follow-up that made the mask a fixed allowlist). - Clean up inconsistencies: drop the empty `Notable Changes` and `API Changes` sections, normalize trailing periods, and tighten blank lines under section headers.
deco-sdk-tagging Bot
added a commit
that referenced
this pull request
Apr 22, 2026
## Release v0.298.0 ### CLI * Added `--limit` flag to all paginated list commands for client-side result capping ([#4984](#4984)). On `jobs list` and `jobs list-runs` the former API page-size flag was renamed to `--page-size` (hidden) to avoid collision. * Accept `yes` in addition to `y` for confirmation prompts, and show `[y/N]` to indicate that no is the default. * Cache `/.well-known/databricks-config` lookups under `~/.cache/databricks/<version>/host-metadata/` so repeat CLI invocations against the same host skip the ~700ms discovery round trip. * Deprecated `auth env`. The command is hidden from help listings and prints a deprecation warning to stderr; it will be removed in a future release. ### Bundles * Remove `experimental-jobs-as-code` template, superseded by `pydabs` ([#4999](#4999)). * Prompt before destroying or recreating Lakebase resources (database instances, synced database tables, postgres projects and branches) ([#5052](#5052)). * Treat deleted resources as not running in the `fail-on-active-runs` check ([#5044](#5044)). * engine/direct: Added support for Vector Search Endpoints ([#4887](#4887)). * engine/direct: Exclude deploy-only fields (e.g. `lifecycle`) from the Apps update mask so requests that change both `description` and `lifecycle.started` in the same deploy no longer fail with `INVALID_PARAMETER_VALUE` ([#5042](#5042), [#5051](#5051)). * engine/direct: Fix phantom diffs from `depends_on` reordering in job tasks ([#4990](#4990)). ### Dependency updates * Bump `github.com/databricks/databricks-sdk-go` from v0.126.0 to v0.128.0 ([#4984](#4984), [#5031](#5031)). * Bump Go toolchain to 1.25.9 ([#5004](#5004)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1163, the pipeline branch of
checkAnyResourceRunninghas swallowed errors while the jobs branch propagated them — an asymmetry with no apparent reasoning for it. #4997 flagged this withnilerrand annotated it as intentional, but it reads as a latent bug. This PR replaces the//nolintwith what the original comments probably meant:apierr.IsMissingmaps 404s to "not running" in bothIsJobRunningandIsPipelineRunning, and genuine errors propagate on both branches.This pull request and its description were written by Isaac.