Fix persistent drift for model permissions object_id after v0.293#4948
Draft
Fix persistent drift for model permissions object_id after v0.293#4948
Conversation
…ration Model permissions object_id changed from /registered-models/MODEL_NAME to /registered-models/NUMERIC_ID, but the state entry __id__ was not updated during deploy, causing perpetual drift on subsequent plans. Add ResourceModelPermissions type with DoUpdateWithID so the state ID is updated when object_id changes. Co-authored-by: Isaac
Approval status: pending
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
__id__was not updated during deploy, causing perpetual drift on subsequent plans.Tests
It was detected by invariant/continue_293 test with the config added in #4941
The test was marked as Slow, so it did not run on PR.