fix(ui): scope processings notifications by department#108
Draft
BatLeDev wants to merge 1 commit into
Draft
Conversation
The processings-list notification subscription passed no sender, so it matched no events (every processings event is published with a sender). Root org accounts now subscribe with :* to receive events from every department of the org (root + departments), while a department-scoped account only subscribes to its own department, avoiding cross-department leakage. This mirrors the reuse-submit fix in data-fair/portals and relies on the :* wildcard support added in the events service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The processings-list notification subscription (
processings-actions.vue) passed nosender, so it matched no events — every processings event is published with asender(run.owner/processing.owner). It now builds a sender scoped to the current account:organization:id:*to receive events from every department of the org (root + departments)organization:id:department, avoiding cross-department leakageuser:id(no wildcard)The sender is repeated per topic since
events'embed/subscribe.vuemapssenders[i]to topici.Why: mirror the reuse-submit notification fix made in data-fair/portals, following the
:*wildcard support added in the events service (work item 61). The per-processing subscription (processing-actions.vue) already carries the owner's concrete department and is unchanged.Heads-up: behavior change — the list previously received no notifications and now does. The
:*wildcard relies on the events service support being deployed.