chore(worker): drop x-processing header and always use private data-fair url#107
Open
BatLeDev wants to merge 1 commit into
Open
chore(worker): drop x-processing header and always use private data-fair url#107BatLeDev wants to merge 1 commit into
BatLeDev wants to merge 1 commit into
Conversation
…air url The x-processing header is no longer consumed: data-fair never read it and the metrics daemon dropped its tracking in favor of x-client. Remove its emission and route all data-fair requests through privateDataFairUrl when set (no more public-url-for-GET-metrics distinction), pruning the now-dead getFromPrivateDataFairUrl config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify how the worker communicates with data-fair.
x-processingprivate header previously attached to every data-fair request.getFromPrivateDataFairUrlconfig flag (envGET_FROM_PRIVATE_DATA_FAIR_URL) and its schema entry.privateDataFairUrlwhen it is configured, instead of only write requests (POST/PUT/DELETE/PATCH).Why: keep all data-fair traffic within internal infrastructure rather than letting read requests leave via the public URL.
Heads-up:
GET_FROM_PRIVATE_DATA_FAIR_URLenv var no longer exists; remove it from any deployment config that still sets it.