feat(traces): tag data-fair requests with x-client: agents#43
Draft
BatLeDev wants to merge 1 commit into
Draft
Conversation
The evaluator's data-exploration tools are the only place this codebase calls the data-fair API directly (server-side tool calls run client-side in the host frame, so they carry data-fair's own referer instead). Send an x-client: agents header on the default ofetch instance so data-fair echoes it back on the response (it allowlists mcp/agents as service clients) and the metrics daemon attributes these requests to the AI agent surface rather than folding them into "Autre". Mirrors the consumer side added in metrics' feat-x-client branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag the agents service's outgoing data-fair requests with an
x-client: agentsheader so data-fair echoes it back and the metrics daemon attributes them to the AI agent surface (rather than folding them into "Autre").The evaluator's data-exploration tools are the only place this codebase calls the data-fair API directly — chat tool calls run client-side in the host frame and carry data-fair's own referer — so the header is set on the single shared default
ofetchinstance, with a unit test covering it.Why: mirror the consumer side added in metrics'
feat-x-clientbranch, where data-fair allowlistsmcp/agentsas service clients and re-emits the header for metrics.