ENH: Generation of compatable device and dtype pairs for test_from_dlpack#443
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
ev-br
left a comment
There was a problem hiding this comment.
Thanks, this seems to work with pytorch now. A couple of further requests below + please remove the now-unused function.
Co-authored-by: Evgeni Burovski <evgeny.burovskiy@gmail.com>
Co-authored-by: Evgeni Burovski <evgeny.burovskiy@gmail.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
|
I'd want to test this on a CUDA-enabled machine locally before merging. The machine is having some issues ATM, meaning I won't be pressing the green button today. |
|
Got help fixing the CUDA issue, and tested on a multi-GPU system with EDIT: the function is |
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
|
Why do we not have CUDA tests in CI? Also, why aren't we testing with different backends in CI, like |
These are hard and $$$ to set up. There is no free CI provider, and those which are not free are not easy to set up and maintain either. cf the current SciPy churn.
This question seems to pop up for every new person who looks at this test suite :-). IME, the most common need is to work in parallel on a branch of |
Closes #440
This is a fairly minimal fix. The new
hh.device_dtype_pairsstrategy generates pairs of all possible (dtype, device) such that dtype is compatible with device.Running:
succeeds, which previously failed for
dtype = float64ondevice = no_float64