BUG: np.matrix is not an array API object#423
Open
ev-br wants to merge 1 commit intodata-apis:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes is_array_api_obj() incorrectly treating numpy.matrix as Array API compatible by explicitly rejecting it, and adds a regression test to ensure np.matrix is not recognized as an Array API object.
Changes:
- Add a
numpy.matrixexclusion inis_array_api_obj(). - Add a NumPy-specific regression test covering
np.matrix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
array_api_compat/common/_helpers.py |
Explicitly returns False for numpy.matrix instances in is_array_api_obj(). |
tests/test_numpy.py |
Adds a regression test asserting np.matrix is not an Array API object. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Being an ndarray subclass, np.matrix inherits the `__array_namespace__` method, even though it is not Array API compatible, and is not meant to be. (Pdb) x matrix([[3]]) (Pdb) p x.__array_namespace__() is np True ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Being an ndarray subclass, np.matrix inherits the
__array_namespace__method, even though it is not Array API compatible, and is not meant to be.closes gh-388