Skip to content

fix(platform-wallet): spv error propagation#3810

Draft
ZocoLini wants to merge 2 commits into
v3.1-devfrom
fix/spv-error-propagation
Draft

fix(platform-wallet): spv error propagation#3810
ZocoLini wants to merge 2 commits into
v3.1-devfrom
fix/spv-error-propagation

Conversation

@ZocoLini

@ZocoLini ZocoLini commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Because start was being called inside the run method, and spawn in background was calling this run method without returning any start error, the spv client could fail to start and nobody was reciting the error. With this PR I force the start method to be called independently, this way start errors are no longer discarded.

Based on PR #3811

Regression tests in PR #3712

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e9a495f3-0915-4eea-9d4b-6b879ee856f4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/spv-error-propagation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZocoLini ZocoLini changed the title Fix/spv error propagation fix(swift-sdk): spv error propagation Jun 8, 2026
@ZocoLini ZocoLini changed the title fix(swift-sdk): spv error propagation fix(platform-wallet): spv error propagation Jun 8, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@ZocoLini ZocoLini force-pushed the fix/spv-error-propagation branch from ae2b976 to f339f1e Compare June 9, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant