backport: Merge bitcoin/bitcoin#27576 - #7665
vijaydasmp wants to merge 1 commit into
Conversation
…nparamsbase from kernel library db77f87 scripted-diff: move settings to common namespace (TheCharlatan) c27e4bd move-only: Move settings to the common library (TheCharlatan) c2dae5d kernel: Remove chainparams, chainparamsbase, args, settings from kernel library (TheCharlatan) 05870b1 refactor: Remove gArgs access from validation.cpp (TheCharlatan) 8789b11 refactor: Add path argument to FindSnapshotChainstateDir (TheCharlatan) ef95be3 refactor: Add stop_at_height option in ChainstateManager (TheCharlatan) Pull request description: This pull request is part of the `libbitcoinkernel` project bitcoin#27587 https://github.com/bitcoin/bitcoin/projects/18 and more specifically its "Step 2: Decouple most non-consensus code from libbitcoinkernel". --- This completes the removal of the node's chainparams, chainparamsbase, args and settings files and their respective classes from the kernel library. This is the last pull request in a long series working towards decoupling the `ArgsManager` and the `gArgs` global from kernel code. These prior pull requests are: bitcoin#26177 bitcoin#27125 bitcoin#25527 bitcoin#25487 bitcoin#25290 ACKs for top commit: MarcoFalke: lgtm ACK db77f87 🍄 hebasto: ACK db77f87, I have reviewed the code and it looks OK. ryanofsky: Code review ACK db77f87. Looks great! Tree-SHA512: cbfbd705d056f2f10f16810d4f869eb152362fff2c5ddae5e1ac6785deae095588e52ad48b29d921962b085e51de1e0ecab6e50f46149ffe3c16250608a2c93a
vijaydasmp
changed the title
|
🕓 Review not started yet because this PR is a draft.
Commit f5a200a. Normal review starts when eligible; priority review starts as soon as a slot is available. |
|
This pull request has conflicts, please rebase. |
|
Thanks for working on this. Closing for now: bitcoin#27576 builds on an earlier chain of refactors that Dash hasn't backported yet, mainly bitcoin#27419 (move-only: extract This can be reopened or resubmitted once those prerequisites have been backported. 🤖 Posted autonomously by Claude on behalf of pasta. |
4 participants
Backporting Bitcoin changes