Skip to content

backport: Merge bitcoin/bitcoin#30278, 28076 - #7654

Closed
vijaydasmp wants to merge 2 commits into
dashpay:developfrom
vijaydasmp:Branch_9_2
Closed

backport: Merge bitcoin/bitcoin#30278, 28076#7654
vijaydasmp wants to merge 2 commits into
dashpay:developfrom
vijaydasmp:Branch_9_2

Conversation

@vijaydasmp

@vijaydasmp vijaydasmp commented Sep 3, 2026

Copy link
Copy Markdown

No description provided.

@fanquake @vijaydasmp
Merge bitcoin#30278: test: cover more errors for `signrawtransactionw…
873098a 
…ithkey` RPC

e2779ce test: cover more errors for `signrawtransactionwithkey` RPC (brunoerg)

Pull request description:

  This PR adds test coverage for the following errors for the `signrawtransactionwithkey` RPC:

  - Invalid private key
  - TX decode failed

  For reference: https://maflcko.github.io/b-c-cov/total.coverage/src/rpc/rawtransaction.cpp.gcov.html

ACKs for top commit:
  maflcko:
    ACK e2779ce
  kevkevinpal:
    ACK [e2779ce](bitcoin@e2779ce)
  tdb3:
    ACK e2779ce
  BrandonOdiwuor:
    Code Review ACK e2779ce

Tree-SHA512: 41c7e990684b60645cf4ccec8aad5ebbe61da221871eb3c1685b2bb1eebda58b29358502cb1525b7c7a2b612e2bebf449ed0bae14ab663b4641c528a9c013b5b
@fanquake @vijaydasmp
Merge bitcoin#28076: util: Replace std::filesystem with util/fs.h
6b4d0e2 
bbbbdb0 ci: Add filesystem lint check (MarcoFalke)
fada2f9 refactor: Replace <filesystem> with <util/fs.h> (MarcoFalke)

Pull request description:

  Using `std::filesystem` is problematic:

  * There is a `fs` namespace wrapper for it. So having two ways to achieve the same is confusing.
  * Not using the `fs` wrapper is dangerous and buggy, because it disables known bugs by deleting problematic functions.

  Fix all issues by removing use of it and adding a linter to avoid using it again in the future.

ACKs for top commit:
  TheCharlatan:
    ACK  bbbbdb0
  fanquake:
    ACK bbbbdb0 🦀

Tree-SHA512: 0e2d49742b08eb2635e6fce41485277cb9c40fe20b81017c391d3472a43787db1278a236825714ca1e41c9d2f59913865cfb0c649e3c8ab1fb598c849f80c660
@vijaydasmp vijaydasmp changed the title backport : Merge bitcoin/bitcoin#30278, 27622 backport : Merge bitcoin/bitcoin#30278, 28076 Sep 4, 2026
@vijaydasmp vijaydasmp changed the title backport : Merge bitcoin/bitcoin#30278, 28076 backport: Merge bitcoin/bitcoin#30278, 28076 Sep 4, 2026
@thepastaclaw

thepastaclaw commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

🕓 Review not started yet because this PR is a draft.

  • Request normal review — click when the PR is ready for review.
  • Request priority review — click to move this review to the front of the queue.

Commit 6b4d0e2. Normal review starts when eligible; priority review starts as soon as a slot is available.

@github-actions

github-actions Bot commented Sep 22, 2026

Copy link
Copy Markdown

This pull request has conflicts, please rebase.

@PastaPastaPasta PastaPastaPasta mentioned this pull request Sep 23, 2026
Closed
1 of 3 tasks
@PastaPastaPasta

PastaPastaPasta commented Sep 23, 2026

Copy link
Copy Markdown
Member

Closing in favour of #7732, which carries only bitcoin#30278 and builds on this PR's cherry-pick. It adds the small bitcoin#28166 hoist of the INPUTS/OUTPUTS vectors and the assert_raises_rpc_error import, which the new test needs on Dash.

bitcoin#28076 was split out because it can't land cleanly yet. It adds a Rust-based lint test_runner, which needs a Rust toolchain in lint CI and conflicts in ci/lint/docker-entrypoint.sh. Its new std::filesystem lint also fails on current develop because of direct uses in src/bitcoin-chainstate.cpp:58-59 and src/policy/fees.cpp:1048-1049, which is why Lint CI failed here. It should come back as its own PR once those uses are converted to fs::.

Thanks vijaydasmp for putting this backport together.

🤖 Posted autonomously by Claude on behalf of pasta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 Awaiting requested review from UdjinM6 UdjinM6 will be requested when the pull request is marked ready for review UdjinM6 is a code owner
@knst knst Awaiting requested review from knst knst will be requested when the pull request is marked ready for review knst is a code owner
@PastaPastaPasta PastaPastaPasta Awaiting requested review from PastaPastaPasta PastaPastaPasta will be requested when the pull request is marked ready for review PastaPastaPasta is a code owner

Assignees

No one assigned

Labels

needs rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vijaydasmp @thepastaclaw @PastaPastaPasta @fanquake