chore: bring bonsplit in-tree and fix top bar window dragging#121
Open
lsoengas wants to merge 2 commits into
Open
chore: bring bonsplit in-tree and fix top bar window dragging#121lsoengas wants to merge 2 commits into
lsoengas wants to merge 2 commits into
Conversation
vendor/bonsplit was a git submodule pointing at manaflow-ai/bonsplit, where we have no push access, so we could not land fixes to it. Per team decision, bring the library into the repo as regular source (MIT license permits this) so bonsplit changes become normal commits and PRs. ghostty stays a submodule fork. Vendored verbatim from manaflow-ai/bonsplit at b2788b1, omitting the Example app, the www site, and upstream CI config. Xcode already consumes it as a local path package (XCLocalSwiftPackageReference), so no build-system changes are needed. Docs and slash commands updated to drop bonsplit from submodule workflows.
The tab bar's empty-space drag zones only moved the window in minimal presentation mode, and the 114pt gutter reserved for the split-action icons was bare SwiftUI padding with no view behind it, so clicks there were swallowed by the scroll view and did nothing. Un-gate the drag zones so the empty strip drags the window in every presentation mode, and replace the dead trailing padding with a real transparent drag-capture view using the same mechanism as the existing 30pt zone after the last tab. Clicks on tabs, drag-to-reorder, hover tracking, and minimal mode's double-click zoom are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Two things, in order:
Per Franco's call: bonsplit comes in-tree, ghostty stays a submodule fork since programa is still a ghostty wrapper.
Summary
Commit 1 - vendoring:
vendor/bonsplitfiles committed verbatim from manaflow-ai/bonsplit @b2788b1e, omitting the Example app, the www site, and upstream CI config.gitmodules(ghostty untouched); no Xcode changes needed since bonsplit was already consumed as a local path package (XCLocalSwiftPackageReference)/pulland/sync-branchcommands, and THIRD_PARTY_LICENSES.md updated (MIT license, provenance recorded)Commit 2 - top bar drag fix (
vendor/bonsplit/.../TabBarView.swift):workspacePresentationMode == "minimal"; the gate is removed so they work in every modeTest Plan
xcodebuildDebug, fresh derived data)No automated regression test: AppKit hit-testing behavior our unit environment cannot exercise end-to-end, per the repo test quality policy.