fix(1023): enable setting DAPR_GRPC_MAX_INBOUND_MESSAGE_SIZE_BYTES through environment variable#1024
Open
CasperGN wants to merge 1 commit into
Open
Conversation
…rough environment variable Signed-off-by: Casper Nielsen <casper@diagrid.io>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
- Coverage 86.63% 81.55% -5.08%
==========================================
Files 84 138 +54
Lines 4473 13491 +9018
==========================================
+ Hits 3875 11003 +7128
- Misses 598 2488 +1890 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acroca
reviewed
May 12, 2026
| elif settings.DAPR_GRPC_MAX_INBOUND_MESSAGE_SIZE_BYTES: | ||
| options.append( | ||
| ( | ||
| 'grpc.max_receive_message_length', |
Member
There was a problem hiding this comment.
Should we set a value to max_send_message_length in this case?
Contributor
Author
There was a problem hiding this comment.
The outbound is supposed to be set to unlimited by default so we'll be able to pass any input size through the outbound channel. If users want to restrict the outbound they can still do so explicitly through the constructor. This conforms to the other SDKs
acroca
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow setting the max message size for GRPC packages through environment variable
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1023
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: