Skip to content

fix(1023): enable setting DAPR_GRPC_MAX_INBOUND_MESSAGE_SIZE_BYTES through environment variable#1024

Open
CasperGN wants to merge 1 commit into
dapr:mainfrom
CasperGN:feat/1023-grpc-max-inbound-message-size
Open

fix(1023): enable setting DAPR_GRPC_MAX_INBOUND_MESSAGE_SIZE_BYTES through environment variable#1024
CasperGN wants to merge 1 commit into
dapr:mainfrom
CasperGN:feat/1023-grpc-max-inbound-message-size

Conversation

@CasperGN
Copy link
Copy Markdown
Contributor

@CasperGN CasperGN commented May 12, 2026

Description

Allow setting the max message size for GRPC packages through environment variable

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1023

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…rough environment variable

Signed-off-by: Casper Nielsen <casper@diagrid.io>
@CasperGN CasperGN requested review from a team as code owners May 12, 2026 09:56
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.55%. Comparing base (bffb749) to head (476b48f).
⚠️ Report is 126 commits behind head on main.

Files with missing lines Patch % Lines
ext/dapr-ext-grpc/dapr/ext/grpc/app.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
- Coverage   86.63%   81.55%   -5.08%     
==========================================
  Files          84      138      +54     
  Lines        4473    13491    +9018     
==========================================
+ Hits         3875    11003    +7128     
- Misses        598     2488    +1890     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

elif settings.DAPR_GRPC_MAX_INBOUND_MESSAGE_SIZE_BYTES:
options.append(
(
'grpc.max_receive_message_length',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set a value to max_send_message_length in this case?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outbound is supposed to be set to unlimited by default so we'll be able to pass any input size through the outbound channel. If users want to restrict the outbound they can still do so explicitly through the constructor. This conforms to the other SDKs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] No way to set the max payload size in Python SDK

2 participants