Skip to content

fix gcp storage bucket binding docs#5157

Open
MyMirelHub wants to merge 2 commits into
dapr:v1.18from
MyMirelHub:fix-docs-for-gcp-storage-bucket
Open

fix gcp storage bucket binding docs#5157
MyMirelHub wants to merge 2 commits into
dapr:v1.18from
MyMirelHub:fix-docs-for-gcp-storage-bucket

Conversation

@MyMirelHub
Copy link
Copy Markdown
Contributor

Description

Fixes multiple issues in the GCP Storage Bucket binding documentation (#5156):

Payload corrections:

  • Fixed move, copy, and rename operation payloads to correctly place destinationBucket/newName in data instead of metadata
  • Split parameter documentation into "metadata parameters" and "data parameters" sections

New documentation:

  • Added comprehensive sign operation documentation with request/response examples
  • Added signTTL to the spec metadata fields table
  • Added note on backward-compatible name metadata key

Fixes:

  • Removed duplicate "GCP Credentials" section
  • Fixed trailing commas in bulkGet example and create response JSON
  • Corrected bulkGet curl examples to use bulkGet instead of bulkget
  • Fixed typos: "kobjects" → "objects", "retuned" → "returned"
  • Fixed anchor links to match section headings
  • Added sign operation to binding support operations list

Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
@MyMirelHub MyMirelHub marked this pull request as ready for review May 8, 2026 10:28
@MyMirelHub MyMirelHub requested review from a team as code owners May 8, 2026 10:28
Copy link
Copy Markdown
Contributor

@nelson-parente nelson-parente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-review for @marcduiker handoff: LGTM. Comprehensive fix for the GCP Storage Bucket binding docs: corrects move/copy/rename payloads (destinationBucket/newName now correctly in data), adds the sign operation with full request/response example, removes the duplicate GCP Credentials section, fixes the bulkgetbulkGet case bug in curl examples, and cleans up several typos. The backward-compat note for the name metadata key is a good touch. Safe to merge after CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants