fix gcp storage bucket binding docs#5157
Open
MyMirelHub wants to merge 2 commits into
Open
Conversation
Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
Contributor
nelson-parente
left a comment
There was a problem hiding this comment.
Pre-review for @marcduiker handoff: LGTM. Comprehensive fix for the GCP Storage Bucket binding docs: corrects move/copy/rename payloads (destinationBucket/newName now correctly in data), adds the sign operation with full request/response example, removes the duplicate GCP Credentials section, fixes the bulkget → bulkGet case bug in curl examples, and cleans up several typos. The backward-compat note for the name metadata key is a good touch. Safe to merge after CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes multiple issues in the GCP Storage Bucket binding documentation (#5156):
Payload corrections:
move,copy, andrenameoperation payloads to correctly placedestinationBucket/newNameindatainstead ofmetadataNew documentation:
signoperation documentation with request/response examplessignTTLto the spec metadata fields tablenamemetadata keyFixes:
bulkGetexample and create response JSONbulkGetcurl examples to usebulkGetinstead ofbulkgetsignoperation to binding support operations list