Fail upgrade tests early when a Dapr Helm chart isn't published#1665
Open
cicoyle wants to merge 1 commit into
Open
Fail upgrade tests early when a Dapr Helm chart isn't published#1665cicoyle wants to merge 1 commit into
cicoyle wants to merge 1 commit into
Conversation
…rs better Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a preflight check to the upgrade E2E test suite so it fails early (with a targeted error message) when a runtime version referenced by supportedUpgradePaths does not have a corresponding published Dapr Helm chart, avoiding later cascading install/role errors.
Changes:
- Introduces
TestMainto run a preflight validation before executing upgrade tests. - Adds helpers to compute which runtime versions are missing charts and to check chart existence in the Dapr Helm repo via HTTP.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+161
to
+168
| func chartPublished(version string) bool { | ||
| resp, err := http.Head(fmt.Sprintf("%s/dapr-%s.tgz", daprHelmRepo, version)) | ||
| if err != nil { | ||
| return false | ||
| } | ||
| defer resp.Body.Close() | ||
| return resp.StatusCode == http.StatusOK | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test that checks each upgrade-path runtime version has a published chart in the Dapr helm repo, so a missing chart fails with a clear msg instead of a cascade of missing-role errors & panic